Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display init container images on the rollout dashboard #3473

Merged
merged 1 commit into from Mar 26, 2024

Conversation

chetan-rns
Copy link
Member

Display init containers on the rollout dashboard. Updates the server to include information regarding the init containers and their images. The UI should include these images and provide an option to edit them.

How to test:

  1. Create a Rollout with an init container
  2. Verify the dashboard displays the image
  3. Try updating the init container image and verify if the Rollout is udpated.
Screenshot 2024-03-26 at 1 34 25 PM

Fixes: #3042
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 142 tests   2 142 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 65c5aa7.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 44m 17s ⏱️
108 tests 100 ✅  6 💤 2 ❌
434 runs  408 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit 65c5aa7.

@zachaller zachaller added this to the v1.7 milestone Mar 26, 2024
@zachaller zachaller merged commit 2ff3c8f into argoproj:master Mar 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose init container images in the dashboard
2 participants