Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout Controller deployment should use the recreate strategy #38

Closed
dthomson25 opened this issue Mar 13, 2019 · 1 comment
Closed
Milestone

Comments

@dthomson25
Copy link
Member

Since we need to have the Argo Rollout Controller to deploy rollouts, we have a chicken and egg problem for deploying the controller. As a result, the rollout controller is deployed with a deployment. Currently, it is deployed using the rolling update strategy. Instead, the controller should use the recreate strategy because controllers operate under the assumption that they are the only one modifying a resource.

@nedal87
Copy link

nedal87 commented Jan 8, 2024

Hi @dthomson25 I've got a PR open for the Argo Helm chart to add a configurable deployment strategy for the Argo Rollouts controller.

Referencing the issue #38 about using "Recreate" strategy. I'm reaching out to get some more insights. Do you see any issues with having it configurable?

I've tested it locally, and all seems good, but I wanted to make sure I'm not missing anything crucial. Your thoughts would be super helpful! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants