New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller doesn't log error when sync handler returns an error #651

Closed

dthomson25 opened this issue Aug 19, 2020 · 1 comment · Fixed by #658

Assignees

Labels

bug

Milestone

Member

dthomson25 commented Aug 19, 2020 •

edited

The following code doesn't log the error returned by the sync handler: https://github.com/argoproj/argo-rollouts/blob/master/utils/controller/controller.go#L144-L161. This does not make it clear what happened, and it should report the error.

dthomson25 changed the title ~~Controller does't~~ Controller doesn't log error when sync handler returns an error

dthomson25 added this to the v0.10 milestone

jessesuen added the bug label

Member

jessesuen commented Aug 20, 2020

Lets put this in the next v0.9.x patch

jessesuen mentioned this issue

fix: add missing log message when a controller's syncHandler returns error #658

Merged

khhirani closed this as completed in #658

jessesuen self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment