Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing log message when a controller's syncHandler returns error #658

Merged
merged 1 commit into from Aug 24, 2020

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Aug 24, 2020

Resolves #651

@codecov-commenter
Copy link

Codecov Report

Merging #658 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #658   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          88       88           
  Lines        8659     8660    +1     
=======================================
+ Hits         7382     7383    +1     
  Misses        903      903           
  Partials      374      374           
Impacted Files Coverage Δ
utils/controller/controller.go 80.30% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992e51d...4d31417. Read the comment docs.

Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khhirani khhirani merged commit 68ba3a8 into argoproj:master Aug 24, 2020
@jessesuen jessesuen deleted the log-controller-error branch August 26, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller doesn't log error when sync handler returns an error
3 participants