Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear ProgressDeadlineExceeded Condition in paused BlueGreen Ro… #1002

Merged
merged 14 commits into from
Mar 1, 2021

Conversation

khhirani
Copy link
Contributor

Closes #939

Signed-off-by: khhirani kareena.hirani@gmail.com

…llout

Signed-off-by: khhirani <kareena.hirani@gmail.com>
@khhirani khhirani changed the title fix: Cllear ProgressDeadlineExceeded Condition in paused BlueGreen Ro… fix: Clear ProgressDeadlineExceeded Condition in paused BlueGreen Ro… Feb 23, 2021
Signed-off-by: khhirani <kareena.hirani@gmail.com>
test/e2e/bluegreen_test.go Outdated Show resolved Hide resolved
test/e2e/bluegreen_test.go Outdated Show resolved Hide resolved
test/e2e/bluegreen_test.go Outdated Show resolved Hide resolved
test/e2e/bluegreen_test.go Outdated Show resolved Hide resolved
test/e2e/bluegreen_test.go Outdated Show resolved Hide resolved
…at it will always be exceeded

Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
…llout

Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
…at it will always be exceeded

Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
…hirani/argo-rollouts into progress-deadline-not-cleared

Signed-off-by: khhirani <kareena.hirani@gmail.com>
@khhirani khhirani force-pushed the progress-deadline-not-cleared branch from 276959d to b9c9e71 Compare February 27, 2021 04:08
@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #1002 (2dae747) into master (1e7b9e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   80.88%   80.90%   +0.01%     
==========================================
  Files         102      102              
  Lines        9082     9080       -2     
==========================================
  Hits         7346     7346              
+ Misses       1241     1240       -1     
+ Partials      495      494       -1     
Impacted Files Coverage Δ
rollout/sync.go 71.82% <ø> (+0.35%) ⬆️
utils/conditions/conditions.go 78.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7b9e2...2dae747. Read the comment docs.

Signed-off-by: khhirani <kareena.hirani@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jessesuen jessesuen merged commit dff1f22 into argoproj:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressDeadlineExceeded condition not cleared in a paused blueGreen rollout
3 participants