Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate scale down count. #1047

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

zcc35357949
Copy link
Contributor

Signed-off-by: zhouchencheng zhouchencheng@bilibili.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1047 (4299c17) into master (bff46e1) will increase coverage by 0.08%.
The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   80.91%   81.00%   +0.08%     
==========================================
  Files         102      103       +1     
  Lines        9097     9166      +69     
==========================================
+ Hits         7361     7425      +64     
- Misses       1242     1246       +4     
- Partials      494      495       +1     
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/status/status.go 93.44% <93.44%> (ø)
pkg/kubectl-argo-rollouts/cmd/cmd.go 100.00% <100.00%> (ø)
utils/replicaset/canary.go 82.40% <100.00%> (ø)
utils/unstructured/unstructured.go 56.52% <0.00%> (-1.26%) ⬇️
metricproviders/newrelic/newrelic.go 92.00% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c1b16...4299c17. Read the comment docs.

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Especially given that this code is difficult to understand.

@jessesuen jessesuen merged commit f594c74 into argoproj:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants