fix: verify analysis arguments name with those in the rollout

[huikang]

• return error if arguments do not match between rollout spec and analysis template

close #1052

[codecov]

Codecov Report

Merging #1071 (6aecdf0) into master (37668f1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   81.00%   81.04%   +0.04%     
==========================================
  Files         103      103              
  Lines        9166     9186      +20     
==========================================
+ Hits         7425     7445      +20     
  Misses       1246     1246              
  Partials      495      495              

Impacted Files	Coverage Δ
.../apis/rollouts/validation/validation_references.go	76.92% <100.00%> (+2.63%)	⬆️
rollout/sync.go	72.37% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37668f1...6aecdf0. Read the comment docs.

[jessesuen]

@khhirani can you review this?

[huikang]

@jessesuen , are we expecting the following case to be passed?

kind: AnalysisTemplate
apiVersion: argoproj.io/v1alpha1
metadata:
  name: sleep-job
spec:
  args:
  - name: duration
    value: 0s
  - name: exit-code
    value: "0"
  - name: count
    value: "1"

kind: Rollout
metadata:
  name: canary-promote-full
spec:
  replicas: 3
  strategy:
    canary:
      maxUnavailable: 0
      analysis:
        templates:
        - templateName: sleep-job

In this case, the Rollout does not provide any args, but the AnalysisTemplate seems having some default value. Is this a valid usage?

[jessesuen]

In this case, the Rollout does not provide any args, but the AnalysisTemplate seems having some default value. Is this a valid usage?

Yes, defaulting is a feature of the AnalysisTemplate.

[huikang]

Yes, defaulting is a feature of the AnalysisTemplate.

Thanks. I have updated PR to consider the default values.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[khhirani]

Hi @huikang , your PR looks good to merge