fix: rollout status always in progressing if analysis fails #1099
Conversation
huikang
force-pushed
the
fix-degraded-status
branch
from
b531789
to
df0ead8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
=======================================
Coverage 81.24% 81.24%
=======================================
Files 104 104
Lines 9420 9420
=======================================
Hits 7653 7653
Misses 1257 1257
Partials 510 510
Continue to review full report at Codecov.
|
- when analysis fails but rollout completes, the status should be degraded Signed-off-by: Hui Kang <hui.kang@salesforce.com>
huikang
force-pushed
the
fix-degraded-status
branch
4 times, most recently
from
b161324
to
2d087c9
Compare
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
huikang
force-pushed
the
fix-degraded-status
branch
from
2d087c9
to
800145a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -585,7 +585,7 @@ func (c *rolloutContext) calculateRolloutConditions(newStatus v1alpha1.RolloutSt | |||
| // In such a case, we should simply not estimate any progress for this rollout. | |||
| currentCond := conditions.GetRolloutCondition(c.rollout.Status, v1alpha1.RolloutProgressing) | |||
|
|
|||
| isCompleteRollout := newStatus.Replicas == newStatus.AvailableReplicas && currentCond != nil && currentCond.Reason == conditions.NewRSAvailableReason | |||
| isCompleteRollout := newStatus.Replicas == newStatus.AvailableReplicas && currentCond != nil && currentCond.Reason == conditions.NewRSAvailableReason && currentCond.Type != v1alpha1.RolloutProgressing | |||
There was a problem hiding this comment.
I just reviewed the calculateRolloutConditions to learn what's going on inside and found one interesting place where I'm a little bit confused:
The next expression currentCond.Type != v1alpha1.RolloutProgressing will always be false as the currentCond is a condition filtered by the v1alpha1.RolloutProgressing type.
That means isCompleteRollout is always false. Maybe we will remove it?
@jessesuen @huikang Please correct me here if I'm wrong.
be degraded
address #942