Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxSurge maxUnavailable zero check #135

Merged
merged 1 commit into from Aug 19, 2019
Merged

Fix maxSurge maxUnavailable zero check #135

merged 1 commit into from Aug 19, 2019

Conversation

dthomson25
Copy link
Member

Fixes #133

@dthomson25 dthomson25 added the bug Something isn't working label Aug 12, 2019
@dthomson25 dthomson25 self-assigned this Aug 12, 2019
@dthomson25 dthomson25 added this to In progress in 2019-08-05 (previous) via automation Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   79.55%   79.69%   +0.13%     
==========================================
  Files          23       23              
  Lines        2186     2201      +15     
==========================================
+ Hits         1739     1754      +15     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/conditions/conditions.go 88.23% <100%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893d673...099ca60. Read the comment docs.

@dthomson25 dthomson25 moved this from In progress to Review in progress in 2019-08-05 (previous) Aug 12, 2019
@dthomson25 dthomson25 added this to the v0.5 milestone Aug 13, 2019
@alexec alexec removed this from Review in progress in 2019-08-05 (previous) Aug 14, 2019
@alexec alexec added this to In progress in 2019-08-14 via automation Aug 14, 2019
@dthomson25 dthomson25 merged commit 7750b15 into master Aug 19, 2019
2019-08-14 automation moved this from In progress to Done Aug 19, 2019
@dthomson25 dthomson25 deleted the fix-max-surge branch August 19, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Rollout incorrectly determines that maxSurge and maxUnavailable are both zero
2 participants