Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor MaxSurge and MaxUnavailable after last step #141

Merged
merged 1 commit into from Aug 19, 2019
Merged

Honor MaxSurge and MaxUnavailable after last step #141

merged 1 commit into from Aug 19, 2019

Conversation

dthomson25
Copy link
Member

Fixes #139

alexmt
alexmt approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Fix appears to be petty simple

@dthomson25 dthomson25 added the bug Something isn't working label Aug 19, 2019
@dthomson25 dthomson25 added this to In progress in 2019-08-28 (last) via automation Aug 19, 2019
@dthomson25 dthomson25 added this to the v0.5 milestone Aug 19, 2019
@dthomson25 dthomson25 self-assigned this Aug 19, 2019
@dthomson25 dthomson25 merged commit c3a2d98 into master Aug 19, 2019
2019-08-28 (last) automation moved this from In progress to Done Aug 19, 2019
@dthomson25 dthomson25 deleted the fix-early-scaledown branch August 19, 2019 17:17
@dthomson25 dthomson25 mentioned this pull request Aug 19, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 20, 2019 •
edited

Codecov Report

Merging #141 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   79.74%   79.62%   -0.13%     
==========================================
  Files          23       23              
  Lines        2207     2194      -13     
==========================================
- Hits         1760     1747      -13     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/replicaset/canary.go 65.59% <100%> (+1.43%) ⬆️
rollout/canary.go 85.94% <100%> (+0.23%) ⬆️
experiments/controller.go 54.94% <0%> (-1.44%) ⬇️
utils/conditions/conditions.go 87.09% <0%> (-1.14%) ⬇️
rollout/controller.go 65.28% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7750b15...9810e44. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #141 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   79.74%   79.62%   -0.13%     
==========================================
  Files          23       23              
  Lines        2207     2194      -13     
==========================================
- Hits         1760     1747      -13     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/replicaset/canary.go 65.59% <100%> (+1.43%) ⬆️
rollout/canary.go 85.94% <100%> (+0.23%) ⬆️
experiments/controller.go 54.94% <0%> (-1.44%) ⬇️
utils/conditions/conditions.go 87.09% <0%> (-1.14%) ⬇️
rollout/controller.go 65.28% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7750b15...9810e44. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #141 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   79.74%   79.62%   -0.13%     
==========================================
  Files          23       23              
  Lines        2207     2194      -13     
==========================================
- Hits         1760     1747      -13     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/replicaset/canary.go 65.59% <100%> (+1.43%) ⬆️
rollout/canary.go 85.94% <100%> (+0.23%) ⬆️
experiments/controller.go 54.94% <0%> (-1.44%) ⬇️
utils/conditions/conditions.go 87.09% <0%> (-1.14%) ⬇️
rollout/controller.go 65.28% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7750b15...9810e44. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #141 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   79.74%   79.62%   -0.13%     
==========================================
  Files          23       23              
  Lines        2207     2194      -13     
==========================================
- Hits         1760     1747      -13     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/replicaset/canary.go 65.59% <100%> (+1.43%) ⬆️
rollout/canary.go 85.94% <100%> (+0.23%) ⬆️
experiments/controller.go 54.94% <0%> (-1.44%) ⬇️
utils/conditions/conditions.go 87.09% <0%> (-1.14%) ⬇️
rollout/controller.go 65.28% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7750b15...9810e44. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019 •
edited

Codecov Report

Merging #141 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   79.74%   79.62%   -0.13%     
==========================================
  Files          23       23              
  Lines        2207     2194      -13     
==========================================
- Hits         1760     1747      -13     
  Misses        334      334              
  Partials      113      113
Impacted Files Coverage Δ
utils/replicaset/canary.go 65.59% <100%> (+1.43%) ⬆️
rollout/canary.go 85.94% <100%> (+0.23%) ⬆️
experiments/controller.go 54.94% <0%> (-1.44%) ⬇️
utils/conditions/conditions.go 87.09% <0%> (-1.14%) ⬇️
rollout/controller.go 65.28% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7750b15...9810e44. Read the comment docs.

@jessesuen jessesuen mentioned this pull request Sep 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees

@dthomson25 dthomson25

Labels
bug Something isn't working
Projects
No open projects
2019-08-28 (last)
Done
Milestone
v0.5 - Argo Experiment and bug fixes
Development

Successfully merging this pull request may close these issues.

Rollout ignores maxSurge and maxUnavailable after executing last step
2 participants
@dthomson25 @alexmt