-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add pagination to FindLoadBalancerByDNSName #1971
Conversation
…alancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1971 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 119 119
Lines 16913 16917 +4
=======================================
+ Hits 13940 13944 +4
Misses 2282 2282
Partials 691 691
Continue to review full report at Codecov.
|
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Kudos, SonarCloud Quality Gate passed!
|
* fix: this close issue #1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com>
* fix: Add pagination to FindLoadBalancerByDNSName (argoproj#1971) * fix: this close issue argoproj#1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com> * fix: missing lb event (argoproj#2021) * fix: turn missing load balancer log into an event Signed-off-by: zachaller <zachaller@hotmail.com> * consistent naming Signed-off-by: zachaller <zachaller@hotmail.com> * fix: Use actual weight from status field on rollout object (argoproj#1937) fix: Use actual weight from status field on rollout object (argoproj#1937) Signed-off-by: zachaller <zachaller@hotmail.com> * fix: build/lint is broken due to dependencies changes (argoproj#1958) Signed-off-by: zachaller <zachaller@hotmail.com> * following github workflow error prompt to fix Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * go fmt Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * make go-mod-vendor Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * fix path Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Co-authored-by: Zach Aller <zachaller@users.noreply.github.com> Co-authored-by: Travis Perdue <travis.perdue@rallyhealth.com>
* fix: this close issue argoproj#1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com>
This adds pagination to the FindLoadBalancerByDNSName function this
should allow argo rollouts to work with any number of loadbalancers.
closes issue #1963
Signed-off-by: zachaller zachaller@hotmail.com