Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: argo-rollouts occasionally crashes in argoproj/pkg #2111

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: argo-rollouts occasionally crashes in argoproj/pkg #2111

merged 2 commits into from
Jun 23, 2022

Conversation

perenesenko
Copy link
Member

@perenesenko perenesenko commented Jun 21, 2022 •
edited
Loading

Signed-off-by: Andrii Perenesenko andrii.perenesenko@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@perenesenko
fix: argo-rollouts occasionally crashes in argoproj/pkg
237b3b7 
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
@perenesenko
Copy link
Member Author

Fix for: #2110

@perenesenko perenesenko linked an issue Jun 21, 2022 that may be closed by this pull request
argo-rollouts occasionally crashes in argoproj/pkg #2110
Closed
@perenesenko perenesenko requested a review from leoluz June 21, 2022 18:15
@perenesenko
fix: argo-rollouts occasionally crashes in argoproj/pkg
ade8fc3 
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2111 (ade8fc3) into master (a6dbe0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         120      120           
  Lines       17440    17440           
=======================================
  Hits        14376    14376           
  Misses       2352     2352           
  Partials      712      712

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dbe0e...ade8fc3. Read the comment docs.

leoluz
leoluz approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harikrongali harikrongali added this to the v1.3 milestone Jun 22, 2022
@leoluz leoluz merged commit 9eef4e2 into argoproj:master Jun 23, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
@perenesenko @jenciso
fix: argo-rollouts occasionally crashes in argoproj/pkg (argoproj#2111)
52abf03 
* fix: argo-rollouts occasionally crashes in argoproj/pkg

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

* fix: argo-rollouts occasionally crashes in argoproj/pkg

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

argo-rollouts occasionally crashes in argoproj/pkg
4 participants
@perenesenko @leoluz @zachaller @harikrongali