fix: switch service selector back to stable on canary service when aborted #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachaller
changed the title
Codecov ReportBase: 81.60% // Head: 81.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
- Coverage 81.60% 81.52% -0.09%
==========================================
Files 130 131 +1
Lines 19483 19587 +104
==========================================
+ Hits 15900 15969 +69
- Misses 2766 2797 +31
- Partials 817 821 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6 tasks
|
@zachaller Any update on this? |
2 tasks
harikrongali
reviewed
Feb 8, 2023
…witch-canary-svc-back-to-stable
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
…witch-canary-svc-back-to-stable
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
harikrongali
approved these changes
Feb 10, 2023
|
Can we merge these changes? |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added a commit
to zachaller/argo-rollouts
that referenced
this pull request
Mar 25, 2024
… when aborted (argoproj#2540)" This reverts commit 81b015d. Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #1838 and #2536
fixes: #2576
Signed-off-by: zachaller zachaller@users.noreply.github.com