Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analysis): fix use stringData in the examples #2715

Merged

Conversation

meeech
Copy link
Contributor

@meeech meeech commented Apr 12, 2023

resolves #2714

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • [n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • [n/a] My organization is added to USERS.md.

@meeech meeech changed the title Use stringData in the examples fix(docs): use stringData in the examples Apr 12, 2023
resolves argoproj#2714

Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
@meeech meeech force-pushed the fix-analysis-docs-secret-example-2714 branch from e9b7038 to a009f89 Compare April 12, 2023 23:55
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@meeech meeech marked this pull request as ready for review April 12, 2023 23:57
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ecb093) 81.47% compared to head (a009f89) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2715   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Go Published Test Results

1 948 tests   1 948 ✔️  2m 34s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit a009f89.

@meeech meeech changed the title fix(docs): use stringData in the examples docs(analysis): fix use stringData in the examples Apr 13, 2023
@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 38m 53s ⏱️
  96 tests   82 ✔️   5 💤   9
398 runs  364 ✔️ 20 💤 14

For more details on these failures, see this check.

Results for commit a009f89.

@zachaller zachaller merged commit b9fbc9b into argoproj:master Apr 13, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Fix example secrets in a few AnalysisTemplates provider doc pages
2 participants