Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quote golang version string to not use go 1.2.2 #2915

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jul 28, 2023

Needed because of:

actions/setup-go#326

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.3% 16.3% Duplication

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (44f9488) 81.75% compared to head (de5b459) 81.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2915   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         133      133           
  Lines       20336    20336           
=======================================
  Hits        16625    16625           
  Misses       2855     2855           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 033 tests   2 033 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit de5b459.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 41m 58s ⏱️
102 tests   86 ✔️   6 💤 10
432 runs  385 ✔️ 24 💤 23

For more details on these failures, see this check.

Results for commit de5b459.

@zachaller zachaller enabled auto-merge (squash) July 28, 2023 22:18
@zachaller zachaller requested a review from leoluz July 28, 2023 22:23
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 4729910 into argoproj:master Jul 28, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants