New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support prometheus headers #2937

Merged

zachaller merged 3 commits into argoproj:master from AhmedGrati:feat-support-prometheus-headers

Aug 7, 2023

Contributor

AhmedGrati commented Aug 7, 2023

Resolves #2925.
Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

TessaIO added 3 commits

August 7, 2023 00:13


          feat: support prometheus headers

b0c54f2

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>


          test: add headers round tripper prometheus headers unit tests

54a3b28

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>


          docs: add headers in prometheus example

ae90910

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

AhmedGrati changed the title ~~Feat support prometheus headers~~ feat: support prometheus headers

Contributor

github-actions bot commented Aug 7, 2023

Go Published Test Results

2 040 tests 2 040 ✔️ 2m 40s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit ae90910.

Contributor

github-actions bot commented Aug 7, 2023

E2E Tests Published Test Results

    4 files     4 suites 3h 36m 30s ⏱️
102 tests   86 ✔️   6 💤 10 ❌
424 runs 384 ✔️ 24 💤 16 ❌

For more details on these failures, see this check.

Results for commit ae90910.

Contributor Author

AhmedGrati commented Aug 7, 2023

zachaller approved these changes

View reviewed changes

zachaller merged commit f0c569b into argoproj:master

21 of 22 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment