Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace antonmedv/expr with expr-lang/expr #3090

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

terrytangyuan
Copy link
Member

The current link is down and the author has created a fork in expr-lang. We use a replace here since the original repo would likely recover once GitHub handles the issue.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba7c9a5) 81.71% compared to head (ce63603) 81.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3090   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files         134      134           
  Lines       20416    20416           
=======================================
  Hits        16683    16683           
  Misses       2873     2873           
  Partials      860      860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Go Published Test Results

2 045 tests   2 045 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit ce63603.

@terrytangyuan
Copy link
Member Author

Let's hold off on merging until the original author confirms.

@terrytangyuan terrytangyuan marked this pull request as draft October 9, 2023 17:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 15s ⏱️
102 tests   87 ✔️   6 💤   9
426 runs  385 ✔️ 24 💤 17

For more details on these failures, see this check.

Results for commit ce63603.

@terrytangyuan
Copy link
Member Author

The author confirmed so we should be good to proceed

@terrytangyuan terrytangyuan marked this pull request as ready for review October 9, 2023 18:39
@zachaller zachaller enabled auto-merge (squash) October 9, 2023 22:55
@zachaller zachaller merged commit 8985fd8 into argoproj:master Oct 9, 2023
24 checks passed
@terrytangyuan terrytangyuan deleted the fix-expr branch October 9, 2023 23:01
zachaller added a commit that referenced this pull request Oct 10, 2023
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Philip Clark <philip.clark@iterable.com>
terrytangyuan added a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants