feat: add analysis modal #3174
feat: add analysis modal #3174
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
+ Coverage 81.81% 81.83% +0.01%
==========================================
Files 135 135
Lines 20629 20629
==========================================
+ Hits 16878 16881 +3
+ Misses 2880 2877 -3
Partials 871 871 ☔ View full report in Codecov by Sentry. |
|
@emily-blixt-ck Analysis tab needs to be color code based on the health status. For e.g. |
| @@ -0,0 +1,79 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Would it better to rename the index.tsx to analysis-modal.tsx
There was a problem hiding this comment.
Yes, that makes sense for consistency. I renamed it.
Thanks for pointing this out! Added a simple status indicator (this doesn't include a sub-status dot, but we could add that too if we want).
|
emily-blixt-ck
force-pushed
the
analysis-modal
branch
from
6befc45
to
705b113
Compare
Signed-off-by: Emily <emily.blixt@creditkarma.com>
emily-blixt-ck
force-pushed
the
analysis-modal
branch
from
705b113
to
4de2e3c
Compare
Signed-off-by: Emily <emily.blixt@creditkarma.com>
| @@ -0,0 +1,2 @@ | |||
| export {default as AnalysisPanel} from './analysis-panel'; | |||
There was a problem hiding this comment.
Yes. This is the Summary Panel that you see when you open the modal. Now that I've typed that... I could rename it to SummaryPanel if that would be more clear.
There was a problem hiding this comment.
Yes, renaming would be better
Signed-off-by: Emily <emily.blixt@creditkarma.com>
|
@zachaller Would you be able to run this locally and verify the UI? |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Emily <emily.blixt@creditkarma.com>
|
|
Thanks for all the hard work! This is a great addition! |
|
We are waiting for this to be released folks! |
|
These are the last features that need to make it in for 1.7 then I should be good to cut a 1.7 release, I will try to get to them soon. |
Checklist:
Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g.
"fix(controller): Updates such and such. Fixes #1234".I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.
Screenshots:
Summary panel
Metric chart demonstrating successes and errors
Table view demonstrating successes and errors
Successful metric chart
Failed metric table
