Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Controller Metrics for Failed Analysis Runs #618

Merged
merged 1 commit into from Aug 25, 2020

Conversation

kcboschert
Copy link
Contributor

This adds the Failed phase status to the analysis_run_metric_phase and analysis_run_phase metrics reported by the controller.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #618 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          87       87           
  Lines        8380     8382    +2     
=======================================
+ Hits         7183     7185    +2     
  Misses        859      859           
  Partials      338      338           
Impacted Files Coverage Δ
controller/metrics/analysis.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc16b8a...7c79565. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This must have been an oversight.

@jessesuen jessesuen changed the title Controller Metrics for Failed Analysis Runs feat: Controller Metrics for Failed Analysis Runs Aug 5, 2020
@jessesuen
Copy link
Member

Could you sign the CLA?

@kcboschert
Copy link
Contributor Author

@jessesuen Signed. How would you like me to resolve the semantic check? Not sure if you'd classify this as fix or feat.

@jessesuen jessesuen merged commit 71d382f into argoproj:master Aug 25, 2020
@jessesuen
Copy link
Member

Yea i think it's more of a fix.

@jessesuen jessesuen changed the title feat: Controller Metrics for Failed Analysis Runs fix: Controller Metrics for Failed Analysis Runs Aug 25, 2020
@kcboschert kcboschert deleted the analysisrun_failed_metrics branch August 25, 2020 20:17
jessesuen pushed a commit that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants