Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support azure auth #664

Merged
merged 1 commit into from Aug 24, 2020
Merged

Conversation

jessesuen
Copy link
Member

Resolves: #449

@codecov-commenter
Copy link

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          88       88           
  Lines        8659     8659           
=======================================
  Hits         7382     7382           
  Misses        903      903           
  Partials      374      374           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992e51d...770c106. Read the comment docs.

Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khhirani khhirani merged commit e9c7722 into argoproj:master Aug 24, 2020
@jessesuen jessesuen deleted the azure-support branch August 24, 2020 23:08
jessesuen added a commit that referenced this pull request Sep 4, 2020
@mateustanaka
Copy link

Hi guys, is there a date for the release of this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: no Auth Provider found for name "azure"
4 participants