fix: do not create background analysisruns with initial deploy #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 82.96% 82.96%
=======================================
Files 95 95
Lines 7915 7915
=======================================
Hits 6567 6567
Misses 947 947
Partials 401 401
Continue to review full report at Codecov.
|
jessesuen
force-pushed
the
skip-initial-analysis-run
branch
from
9d1424e
to
ed2964b
Compare
jessesuen
added a commit
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #714
The check for detecting an initial deploy and conditionally creating a background analysisrun was incomplete. It did not catch a scenario where
Rollout.Status.StableRS == "". Not sure why this is true in v0.9. but not v0.8This is stacked ontop of another PR so only look at 9d1424e