Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: analysis controller could get into a hotloop with terminated run #724

Merged
merged 1 commit into from Sep 21, 2020
Merged

fix: analysis controller could get into a hotloop with terminated run #724

merged 1 commit into from Sep 21, 2020

Conversation

jessesuen
Copy link
Member

Resolves #723

@codecov-commenter
Copy link

Codecov Report

Merging #724 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files          95       95           
  Lines        7876     7882    +6     
=======================================
+ Hits         6552     6557    +5     
- Misses        928      929    +1     
  Partials      396      396
Impacted Files Coverage Δ
analysis/analysis.go 85.83% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8981545...92b2842. Read the comment docs.

khhirani
khhirani approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit ca646c5 into argoproj:master Sep 21, 2020
@jessesuen jessesuen deleted the analysis-run-hotloop branch September 21, 2020 21:09
jessesuen added a commit that referenced this pull request Sep 22, 2020
@jessesuen
fix: analysis controller could get into a hotloop with terminated run (…
92b0598 
…#724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khhirani khhirani khhirani approved these changes

Assignees

@khhirani khhirani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analysisrun in a reconciliation hotloop
3 participants
@jessesuen @codecov-commenter @khhirani