Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix unhandled panic from malformed rollout #801

Merged
merged 1 commit into from Oct 26, 2020

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Oct 24, 2020

Resolves #800

Signed-off-by: Jesse Suen jesse_suen@intuit.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
@codecov-io
Copy link

Codecov Report

Merging #801 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files          96       96           
  Lines        8196     8198    +2     
=======================================
+ Hits         6748     6750    +2     
  Misses       1037     1037           
  Partials      411      411           
Impacted Files Coverage Δ
utils/service/service.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98a274...1c41310. Read the comment docs.

Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 8b0fe30 into argoproj:master Oct 26, 2020
@jessesuen jessesuen deleted the malformed-rollout-panic branch October 26, 2020 22:34
jessesuen added a commit that referenced this pull request Oct 27, 2020
Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollouts controller panics when there's an invalid Rollout
3 participants