fix: (controller boot) Do not cache all cluster Secrets - fetch them on demand. Fixes #798 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 82.09% 82.09% -0.01%
==========================================
Files 98 98
Lines 8523 8522 -1
==========================================
- Hits 6997 6996 -1
Misses 1085 1085
Partials 441 441
Continue to review full report at Codecov.
|
mrak
changed the title
Using a list cache of secrets is not needed as we do not need to react to any changes and we can always fetch the individual secrets we need for analysis arguments when the time comes. For large kubernetes clusters with thousands of secrets this causes the argo-rollouts controller to be unbootable. Co-authored-by: Jason Yanowitz <jason.yanowitz@getbraintree.com> Signed-off-by: Eric Mrak <emrak@paypal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a list cache of secrets is not needed as we do not need to react
to any changes and we can always fetch the individual secrets we need
for analysis arguments when the time comes. For large kubernetes
clusters with thousands of secrets this causes the argo-rollouts
controller to be unbootable.
Checklist:
(a) I've created an enhancement proposal and discussed it with the community,(b) this is a bug fix,or (c) this is a chore."fix(controller): Updates such and such. Fixes #1234".My organization is added to USERS.md.