Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get rollout always return not found except default namespace #961

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

zcc35357949
Copy link
Contributor

Signed-off-by: zhouchencheng zhouchencheng@bilibili.com

affected by #932, rollout cli can not get rollout in other namespaces except default.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zcc35357949
Copy link
Contributor Author

@zhaoyun006

@jessesuen jessesuen merged commit c0d3672 into argoproj:master Jan 25, 2021
@jessesuen
Copy link
Member

Thank you!

zhaoyun006 pushed a commit to zhaoyun006/argo-rollouts that referenced this pull request Feb 11, 2021
…goproj#961)

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
zhaoyun006 pushed a commit to zhaoyun006/argo-rollouts that referenced this pull request Feb 12, 2021
…goproj#961)

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants