feat: Allow user to handle NaN result in Analysis #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 81.35% 81.26% -0.09%
==========================================
Files 100 100
Lines 8837 8859 +22
==========================================
+ Hits 7189 7199 +10
- Misses 1180 1186 +6
- Partials 468 474 +6
Continue to review full report at Codecov.
|
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -643,3 +643,112 @@ spec: | |||
| value: "Bearer {{ args.api-token }}" | |||
| ``` | |||
|
|
|||
| ## Handling Metric Results - NaN and Infinity | |||
| Metric providers can sometimes return values of NaN (not a number) and infinity. Users can edit the `successCondition` and `failureCondition` fields | |||
There was a problem hiding this comment.
I think we should mention the functions in the doc wording. Can you explain the fact that we provide two math functions isNaN and isInf as a convenience to allow users to customize the handling of it and what they return (it may not be obvious to everyone). Also note that if not handled, a NaN result could result in Failed measurements.
Also, please add:
!!! important
available since v1.0
|
Function isNaN(result) giving error. |
Closes #459