Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): standardize Stale Action config #551

Merged
merged 1 commit into from
May 28, 2024

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented May 4, 2024

Motivation

  • fix OpenSSF Scorecard issues
  • have consistent settings here as in Workflows

Modifications

  • fix OpenSSF Scorecard issues

    • set top-level permissions to read-only
    • add comments for job-level permissions
    • pin action to a SHA
  • use same settings as Workflows

    • with a dedicated stale-issue-message & stale-pr-message
    • same cron schedule
    • same formatting: indentionation and ordering etc

Notes to Reviewers

This will merge conflict with #549 (due to indentation etc changes), so it is a draft for now

- fix OpenSSF Scorecard issues
  - set top-level `permissions` to read-only
  - add comments for job-level `permissions`
  - pin action to a SHA

- use same settings as Workflows
  - with a dedicated `stale-issue-message` & `stale-pr-message`
  - same cron `schedule`
  - same formatting: indentionation and ordering etc

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5
Copy link
Member Author

This will merge conflict with #549 (due to indentation etc changes), so it is a draft for now

Rebased on top of #549 and fixed all merge conflicts, ready for review now

@agilgur5 agilgur5 marked this pull request as ready for review May 12, 2024 03:25
Copy link
Member

@isubasinghe isubasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agilgur5 agilgur5 merged commit 4836620 into argoproj:master May 28, 2024
5 checks passed
@agilgur5 agilgur5 deleted the ci-stale-standardize branch May 28, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants