fix: Fixed mutex with withSequence in http template broken. Fixes #12018

(#12176) Signed-off-by: shmruin <meme_hm@naver.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
argoproj · Feb 28, 2024 · 16c4970 · 16c4970
1 parent 23b1a4b
commit 16c4970
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/apis/workflow/v1alpha1/workflow_types.go b/pkg/apis/workflow/v1alpha1/workflow_types.go
@@ -3015,6 +3015,8 @@ func (tmpl *Template) GetNodeType() NodeType {
 		return NodeTypeSteps
 	case TemplateTypeSuspend:
 		return NodeTypeSuspend
+	case TemplateTypeHTTP:
+		return NodeTypeHTTP
 	case TemplateTypePlugin:
 		return NodeTypePlugin
 	}

diff --git a/workflow/controller/http_template.go b/workflow/controller/http_template.go
@@ -8,6 +8,8 @@ func (woc *wfOperationCtx) executeHTTPTemplate(nodeName string, templateScope st
 	node, err := woc.wf.GetNodeByName(nodeName)
 	if err != nil {
 		node = woc.initializeExecutableNode(nodeName, wfv1.NodeTypeHTTP, templateScope, tmpl, orgTmpl, opts.boundaryID, wfv1.NodePending, opts.nodeFlag)
+	}
+	if !node.Fulfilled() {
 		woc.taskSet[node.ID] = *tmpl
 	}
 	return node