Skip to content

Commit

Permalink
fix: Fix for missing steps in the UI (#12203)
Browse files Browse the repository at this point in the history
Signed-off-by: Alan Clucas <alan@clucas.org>
  • Loading branch information
Joibel committed Nov 15, 2023
1 parent 18c5925 commit 206c901
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions workflow/controller/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,11 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
return node, err
}
if outputs != nil {
node, err = woc.wf.GetNodeByName(nodeName)
if err != nil {
woc.log.Errorf("unable to get node by name for %s", nodeName)
return nil, err
}
node.Outputs = outputs
woc.wf.Status.Nodes.Set(node.ID, *node)
}
Expand Down
4 changes: 4 additions & 0 deletions workflow/controller/steps.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ func (woc *wfOperationCtx) executeSteps(ctx context.Context, nodeName string, tm
}

if outputs != nil {
node, err := woc.wf.GetNodeByName(nodeName)
if err != nil {
return nil, err
}
node.Outputs = outputs
woc.addOutputsToGlobalScope(node.Outputs)
woc.wf.Status.Nodes.Set(node.ID, *node)
Expand Down

0 comments on commit 206c901

Please sign in to comment.