Skip to content

Commit

Permalink
fix(server): don't grab SAs if SSO RBAC is not enabled (#11426)
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
  • Loading branch information
agilgur5 committed Aug 11, 2023
1 parent 105031b commit 311214c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions server/apiserver/argoserver.go
Expand Up @@ -142,8 +142,11 @@ func NewArgoServer(ctx context.Context, opts ArgoServerOpts) (*argoServer, error
if err != nil {
return nil, err
}
resourceCache = cache.NewResourceCache(opts.Clients.Kubernetes, getResourceCacheNamespace(opts))
resourceCache.Run(ctx.Done())
if ssoIf.IsRBACEnabled() {
// resourceCache is only used for SSO RBAC
resourceCache = cache.NewResourceCache(opts.Clients.Kubernetes, getResourceCacheNamespace(opts))
resourceCache.Run(ctx.Done())
}
log.Info("SSO enabled")
} else {
log.Info("SSO disabled")
Expand Down

0 comments on commit 311214c

Please sign in to comment.