feat(controller): optional database migration

Signed-off-by: book987 <book78987book@gmail.com>
argoproj · Jan 15, 2021 · 34498cd · 34498cd
1 parent a8e9348
commit 34498cd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/config/config.go b/config/config.go
@@ -150,6 +150,7 @@ type PersistConfig struct {
 	ConnectionPool *ConnectionPool   `json:"connectionPool,omitempty"`
 	PostgreSQL     *PostgreSQLConfig `json:"postgresql,omitempty"`
 	MySQL          *MySQLConfig      `json:"mysql,omitempty"`
+	SkipMigration  bool              `json:"skipMigration,omitempty"`
 }
 
 func (c PersistConfig) GetArchiveLabelSelector() (labels.Selector, error) {

diff --git a/docs/workflow-controller-configmap.yaml b/docs/workflow-controller-configmap.yaml
@@ -179,6 +179,8 @@ data:
       archive: false
       # the number of days to keep archived workflows (the default is forever)
       archiveTTL: 180d
+      # skip database migration if needed.
+      # skipMigration: true
 
       # LabelSelector determines the workflow that matches with the matchlabels or matchrequirements, will be archived.
       # https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/

diff --git a/workflow/controller/config.go b/workflow/controller/config.go
@@ -46,9 +46,13 @@ func (wfc *WorkflowController) updateConfig(v interface{}) error {
 			return err
 		}
 		log.Info("Persistence Session created successfully")
-		err = sqldb.NewMigrate(session, persistence.GetClusterName(), tableName).Exec(context.Background())
-		if err != nil {
-			return err
+		if !persistence.SkipMigration {
+			err = sqldb.NewMigrate(session, persistence.GetClusterName(), tableName).Exec(context.Background())
+			if err != nil {
+				return err
+			}
+		} else {
+			log.Info("DB migration is disabled")
 		}
 
 		wfc.session = session