fix: Checkbox is not clickable (#5213)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
argoproj · Feb 25, 2021 · 694690b · 694690b
1 parent f0e8df0
commit 694690b
Showing 1 changed file with 22 additions and 20 deletions.
diff --git a/ui/src/app/workflows/components/workflows-row/workflows-row.tsx b/ui/src/app/workflows/components/workflows-row/workflows-row.tsx
@@ -1,6 +1,5 @@
 import {Ticker} from 'argo-ui/src/index';
 import * as React from 'react';
-import {Link} from 'react-router-dom';
 import {Workflow} from '../../../../models';
 import {uiUrl} from '../../../shared/base';
 import {DurationPanel} from '../../../shared/components/duration-panel';
@@ -31,23 +30,26 @@ export class WorkflowsRow extends React.Component<WorkflowsRowProps, WorkflowRow
     public render() {
         const wf = this.props.workflow;
         return (
-            <Link to={uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`)}>
-                <div className='workflows-list__row-container'>
-                    <div className='row argo-table-list__row'>
-                        <div className='columns small-1 workflows-list__status'>
-                            <input
-                                type='checkbox'
-                                className='workflows-list__status--checkbox'
-                                checked={this.props.checked}
-                                onClick={e => {
-                                    e.stopPropagation();
-                                }}
-                                onChange={e => {
-                                    this.props.select(this.props.workflow);
-                                }}
-                            />
-                            <PhaseIcon value={wf.status.phase} />
-                        </div>
+            <div className='workflows-list__row-container'>
+                <div className='row argo-table-list__row'>
+                    <div className='columns small-1 workflows-list__status'>
+                        <input
+                            type='checkbox'
+                            className='workflows-list__status--checkbox'
+                            checked={this.props.checked}
+                            onClick={e => {
+                                e.stopPropagation();
+                            }}
+                            onChange={e => {
+                                this.props.select(this.props.workflow);
+                            }}
+                        />
+                        <PhaseIcon value={wf.status.phase} />
+                    </div>
+                    <a
+                        href={uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`)}
+                        className='small-11 row'
+                        ref={el => el && el.style.setProperty('max-width', '91.6666666667%', 'important')}>
                         <div className='columns small-2'>{wf.metadata.name}</div>
                         <div className='columns small-2'>{wf.metadata.namespace}</div>
                         <div className='columns small-1'>
@@ -92,9 +94,9 @@ export class WorkflowsRow extends React.Component<WorkflowsRowProps, WorkflowRow
                                 }}
                             />
                         )}
-                    </div>
+                    </a>
                 </div>
-            </Link>
+            </div>
         );
     }
 }