fix: open minio dashboard on different port in quick-start (#8407)

Signed-off-by: Grzegorz Bielski <pesiok@gmail.com>
argoproj · Aug 8, 2022 · 6ec0ca0 · 6ec0ca0
1 parent d874c1a
commit 6ec0ca0
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 6 deletions.
diff --git a/docs/configure-artifact-repository.md b/docs/configure-artifact-repository.md
@@ -23,6 +23,7 @@ The actual repository used by a workflow is chosen by the following rules:
 3. From a workflow controller configmap.
 
 ## Configuring Minio
+NOTE: Minio is already included in the [quick-start manifests](quick-start.md).
 
 ```
 $ brew install helm # mac, helm 3.x

diff --git a/manifests/quick-start-minimal.yaml b/manifests/quick-start-minimal.yaml
@@ -1273,9 +1273,14 @@ metadata:
   name: minio
 spec:
   ports:
-  - port: 9000
+  - name: api
+    port: 9000
     protocol: TCP
     targetPort: 9000
+  - name: dashboard
+    port: 9001
+    protocol: TCP
+    targetPort: 9001
   selector:
     app: minio
 ---
@@ -1377,6 +1382,8 @@ spec:
       - command:
         - minio
         - server
+        - --console-address
+        - :9001
         - /data
         env:
         - name: MINIO_ACCESS_KEY
@@ -1400,6 +1407,9 @@ spec:
         name: main
         ports:
         - containerPort: 9000
+          name: api
+        - containerPort: 9001
+          name: dashboard
         readinessProbe:
           httpGet:
             path: /minio/health/ready

diff --git a/manifests/quick-start-mysql.yaml b/manifests/quick-start-mysql.yaml
@@ -1303,9 +1303,14 @@ metadata:
   name: minio
 spec:
   ports:
-  - port: 9000
+  - name: api
+    port: 9000
     protocol: TCP
     targetPort: 9000
+  - name: dashboard
+    port: 9001
+    protocol: TCP
+    targetPort: 9001
   selector:
     app: minio
 ---
@@ -1421,6 +1426,8 @@ spec:
       - command:
         - minio
         - server
+        - --console-address
+        - :9001
         - /data
         env:
         - name: MINIO_ACCESS_KEY
@@ -1444,6 +1451,9 @@ spec:
         name: main
         ports:
         - containerPort: 9000
+          name: api
+        - containerPort: 9001
+          name: dashboard
         readinessProbe:
           httpGet:
             path: /minio/health/ready

diff --git a/manifests/quick-start-postgres.yaml b/manifests/quick-start-postgres.yaml
@@ -1303,9 +1303,14 @@ metadata:
   name: minio
 spec:
   ports:
-  - port: 9000
+  - name: api
+    port: 9000
     protocol: TCP
     targetPort: 9000
+  - name: dashboard
+    port: 9001
+    protocol: TCP
+    targetPort: 9001
   selector:
     app: minio
 ---
@@ -1421,6 +1426,8 @@ spec:
       - command:
         - minio
         - server
+        - --console-address
+        - :9001
         - /data
         env:
         - name: MINIO_ACCESS_KEY
@@ -1444,6 +1451,9 @@ spec:
         name: main
         ports:
         - containerPort: 9000
+          name: api
+        - containerPort: 9001
+          name: dashboard
         readinessProbe:
           httpGet:
             path: /minio/health/ready

diff --git a/manifests/quick-start/base/minio/minio-deploy.yaml b/manifests/quick-start/base/minio/minio-deploy.yaml
@@ -23,7 +23,10 @@ spec:
               value: password
           ports:
             - containerPort: 9000
-          command: [minio, server, /data]
+              name: api
+            - containerPort: 9001
+              name: dashboard
+          command: [minio, server, --console-address, ":9001", /data]
           lifecycle:
             postStart:
               exec:

diff --git a/manifests/quick-start/base/minio/minio-service.yaml b/manifests/quick-start/base/minio/minio-service.yaml
@@ -8,6 +8,11 @@ spec:
   selector:
     app: minio
   ports:
-    - protocol: TCP
-      port: 9000
+    - port: 9000
+      name: api
+      protocol: TCP
       targetPort: 9000
+    - port: 9001
+      name: dashboard
+      protocol: TCP
+      targetPort: 9001