fix: leak stream (#12193)

Signed-off-by: weidongcai <cwdsuzhou@gmail.com>
argoproj · Nov 20, 2023 · 9eadf2d · 9eadf2d
1 parent 75d7eb1
commit 9eadf2d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/util/logs/workflow-logger.go b/util/logs/workflow-logger.go
@@ -132,7 +132,11 @@ func WorkflowLogs(ctx context.Context, wfClient versioned.Interface, kubeClient
 					logCtx.Error(err)
 					return
 				}
-
+				defer func() {
+					if err := stream.Close(); err != nil {
+						logCtx.Warn("Failed to close stream", err)
+					}
+				}()
 				scanner := bufio.NewScanner(stream)
 				//give it more space for long line
 				scanner.Buffer(make([]byte, startBufSize), maxTokenLength)