Skip to content

Commit

Permalink
docs: re-word the TODO with more details
Browse files Browse the repository at this point in the history
Signed-off-by: vadasambar <suraj.bankar@acquia.com>
  • Loading branch information
vadasambar committed Aug 25, 2023
1 parent 0910763 commit b06ce13
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion workflow/executor/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,8 @@ func runKubectl(args ...string) ([]byte, error) {
var buf bytes.Buffer
if err := kubectlcmd.NewKubectlCommand(kubectlcmd.KubectlOptions{
Arguments: args,
// TODO(vadasambar): re-visit this once https://github.com/kubernetes/kubernetes/pull/120024 is merged
// TODO(vadasambar): use `DefaultConfigFlags` variable from upstream
// as value for `ConfigFlags` once https://github.com/kubernetes/kubernetes/pull/120024 is merged
ConfigFlags: genericclioptions.NewConfigFlags(true).
WithDeprecatedPasswordFlag().
WithDiscoveryBurst(300).
Expand Down

0 comments on commit b06ce13

Please sign in to comment.