fix: Check file size before saving to artifact storage. Fixes #10902 (#…

…10903) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
argoproj · Apr 19, 2023 · b846eeb · b846eeb
1 parent 0b59428
commit b846eeb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/workflow/executor/executor.go b/workflow/executor/executor.go
@@ -318,6 +318,14 @@ func (we *WorkflowExecutor) saveArtifact(ctx context.Context, containerName stri
 		}
 		return err
 	}
+	fi, err := os.Stat(localArtPath)
+	if err != nil {
+		return err
+	}
+	size := fi.Size()
+	if size == 0 {
+		log.Warnf("The file %q is empty. It may not be uploaded successfully depending on the artifact driver", localArtPath)
+	}
 	return we.saveArtifactFromFile(ctx, art, fileName, localArtPath)
 }