fix: don't fail workflow if PDB creation fails (#13102)

Signed-off-by: Alan Clucas <alan@clucas.org>
argoproj · Jun 9, 2024 · cc604e4 · cc604e4
1 parent effcab7
commit cc604e4
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -283,16 +283,16 @@ func (woc *wfOperationCtx) operate(ctx context.Context) {
 	}
 
 	if woc.wf.Status.Phase == wfv1.WorkflowUnknown {
-		woc.markWorkflowRunning(ctx)
-		setWfPodNamesAnnotation(woc.wf)
-
 		err := woc.createPDBResource(ctx)
 		if err != nil {
-			msg := fmt.Sprintf("Unable to create PDB resource for workflow, %s error: %s", woc.wf.Name, err)
-			woc.markWorkflowFailed(ctx, msg)
+			woc.log.WithError(err).WithField("workflow", woc.wf.Name).Error("PDB creation failed")
+			woc.requeue()
 			return
 		}
 
+		woc.markWorkflowRunning(ctx)
+		setWfPodNamesAnnotation(woc.wf)
+
 		woc.workflowDeadline = woc.getWorkflowDeadline()
 
 		// Workflow will not be requeued if workflow steps are in pending state.