fix: only aggregates output from successful nodes (#7517)

* fix: only aggregates outputs for successful retry nodes Signed-off-by: Dillen Padhiar <dpadhiar99@gmail.com> * fix: does not aggregate output from retry child nodes anymore Signed-off-by: Dillen Padhiar <dpadhiar99@gmail.com>
argoproj · Jan 27, 2022 · db58583 · db58583
1 parent 38fdf4c
commit db58583
Show file tree

Hide file tree

Showing 2 changed files with 446 additions and 1 deletion.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -2687,7 +2687,7 @@ func (woc *wfOperationCtx) processAggregateNodeOutputs(scope *wfScope, prefix st
 	outputParamValueLists := make(map[string][]string)
 	resultsList := make([]wfv1.Item, 0)
 	for _, node := range childNodes {
-		if node.Outputs == nil {
+		if node.Outputs == nil || node.Phase != wfv1.NodeSucceeded || node.Type == wfv1.NodeTypeRetry {
 			continue
 		}
 		if len(node.Outputs.Parameters) > 0 {