fix: Make devcontainer able to pre-commit (#11153)

Signed-off-by: Alan Clucas <alan@clucas.org>
argoproj · Jul 19, 2023 · dcc4f58 · dcc4f58
1 parent 5ef42ee
commit dcc4f58
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -16,4 +16,8 @@
   "onCreateCommand": ".devcontainer/pre-build.sh",
   "workspaceMount": "source=${localWorkspaceFolder},target=/home/vscode/go/src/github.com/argoproj/argo-workflows,type=bind",
   "workspaceFolder": "/home/vscode/go/src/github.com/argoproj/argo-workflows"
+  "remoteEnv": {
+	"PATH": "${containerEnv:PATH}:/home/vscode/go/bin",
+    "GOPATH": "/home/vscode/go"
+  }
 }
diff --git a/.devcontainer/pre-build.sh b/.devcontainer/pre-build.sh
@@ -15,5 +15,12 @@ kubectl cluster-info
 # install kit
 curl -q https://raw.githubusercontent.com/kitproj/kit/main/install.sh | sh
 
+# install protocol buffer compiler (protoc)
+sudo apt update
+sudo apt install -y protobuf-compiler
+
+# Make sure go path is owned by vscode
+sudo chown -R vscode:vscode /home/vscode/go
+
 # download dependencies and do first-pass compile
 CI=1 kit pre-up