Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep ensure doesnt generate examples folder. #1076

Closed
Akado2009 opened this issue Nov 4, 2018 · 1 comment
Closed

Dep ensure doesnt generate examples folder. #1076

Akado2009 opened this issue Nov 4, 2018 · 1 comment

Comments

@Akado2009
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:
A bug report.
What happened:
Trying to dep ensure
What you expected to happen:
Expect to have exmaples folder in ./vendor/github.com/argoproj/argo/ so they will match sym links from ./vendor/github.com/argoproj/argo/test/e2e/expectedfailures/*.

How to reproduce it (as minimally and precisely as possible):
Just create a new project, dep init, paste this in Gopkg.toml

  name = "github.com/argoproj/argo"
  branch = "master"

Then just create a simple main file:


import (
	argoproj "github.com/argoproj/argo/pkg/client/clientset/versioned/typed/workflow/v1alpha1"
	"fmt"
)

type KubebenchJobController struct {
	Workflows argoproj.WorkflowInterface
}

func main() {
	a := KubebenchJobController{}
	fmt.Println(a)
}

Then just simple do dep ensure and check ./vendor/github.com/argoproj/argo
Environment:
MacOS

@jessesuen
Copy link
Member

This is controlled by dep, which provides some flags which allow you to keep non-go code in the vendor directory. See:

golang/dep#1731 (comment)

icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this issue Jan 5, 2022
* fix: tls config validation, follow up on argoproj#1070

Signed-off-by: Derek Wang <whynowy@gmail.com>

* test cases

Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants