Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo workflow UI compilation error #11183

Closed
2 of 3 tasks
chethan-devopsnow opened this issue Jun 6, 2023 · 6 comments
Closed
2 of 3 tasks

Argo workflow UI compilation error #11183

chethan-devopsnow opened this issue Jun 6, 2023 · 6 comments
Labels
area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies P3 Low priority type/bug type/dependencies PRs and issues specific to updating dependencies

Comments

@chethan-devopsnow
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Cloned the latest argo-workflow repo
Followed every steps mentioned here f
Opened the code is VSCode and ran open in dev container
make start UI=true
I was supposed to see a properly working argo ui but found compilation error
Screenshot 2023-06-06 at 9 20 06 AM

Version

v3.4.8

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

git clone git@github.com:argoproj/argo-workflows.git
set $GOPATH ~/home/go/src/github.com/argoproj/argo-workflows
Use dev container plugin on vscode to open the repo
edit the hosts file and add the following entries 
127.0.0.1 dex
127.0.0.1 minio
127.0.0.1 postgres
127.0.0.1 mysql
127.0.0.1 azurite
Run make start and then stop and run make start UI=true
Access the frontend on localhost:8080

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@chethan-devopsnow
Copy link
Author

Findings:
Error: Your lockfile needs to be updated, but yarn was run with --frozen-lockfile so I deleted the yarn.lock file on the local UI folder and ran the make start command to see it with compilation error

@juliev0
Copy link
Contributor

juliev0 commented Jun 8, 2023

@Joibel I think you use Dev Container, right? Any comments here?

@juliev0 juliev0 added the P3 Low priority label Jun 8, 2023
@Joibel
Copy link
Member

Joibel commented Jun 9, 2023

I can reproduce this inside a dev container by deleting ui/yarn.lock, but the UI builds OK if you don't do that.
I am unable to build the UI outside of a dev container at the moment, so can't compare to see if it does work correctly outside, and I'm not enough of a UI person to diagnose further.

@Joibel
Copy link
Member

Joibel commented Jun 9, 2023

As far as I can tell just deleting yarn.lock and hoping for the best isn't normally successful, and actual curated updating is the way to go. I'm not sure this is a bug as such.

@juliev0
Copy link
Contributor

juliev0 commented Jun 9, 2023

thanks for checking @Joibel !

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies labels Sep 1, 2023
@agilgur5
Copy link
Member

agilgur5 commented Sep 1, 2023

Agreed with the above; deleting yarn.lock means changing build versions and is not a normal procedure.

The specific build error mentioned here is from upgrading swagger-ui-react, which I investigated in #11640 and is no longer relevant either.

So this is not a bug per both of the above.

Error: Your lockfile needs to be updated, but yarn was run with --frozen-lockfile

If you want to intentionally update a dependency, you can temporarily remove the --frozen-lockfile setting from the .yarnrc. I have done this quite frequently recently as I've been updating the UI build (e.g. #11628) and deps

@agilgur5 agilgur5 closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies P3 Low priority type/bug type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

No branches or pull requests

4 participants