Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron Workflow Controller should use WorkflowTemplateInformer and ClusterWorkflowTemplateInformer #11372

Closed
juliev0 opened this issue Jul 17, 2023 · 2 comments · Fixed by #11470
Closed

Cron Workflow Controller should use WorkflowTemplateInformer and ClusterWorkflowTemplateInformer #11372

juliev0 opened this issue Jul 17, 2023 · 2 comments · Fixed by #11470
Assignees
@juliev0
Labels
area/controller Controller issues, panics area/cron-workflows area/workflow-templates type/feature Feature request

Comments

@juliev0
Copy link
Contributor

juliev0 commented Jul 17, 2023

Summary

It seems to me that the CronWorkflow validation code is unnecessarily calling the K8S API to "GET WorkflowTemplate" here (for CronWorkflows that use WorkflowTemplates) when it could be using the Informer.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@juliev0 juliev0 added the type/feature Feature request label Jul 17, 2023
@juliev0 juliev0 self-assigned this Jul 17, 2023
@juliev0 juliev0 mentioned this issue Jul 17, 2023
Closed
@terrytangyuan terrytangyuan mentioned this issue Jul 18, 2023
Closed
@terrytangyuan
Copy link
Member

Others feel free to pick this up

@juliev0 juliev0 self-assigned this Jul 19, 2023
@juliev0
Copy link
Contributor Author

juliev0 commented Jul 19, 2023

I think I'll have time to work on this sometime soon so taking back :)

@laughingman7743 laughingman7743 mentioned this issue Jul 27, 2023
Closed
@juliev0 juliev0 mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliev0 juliev0

Labels
area/controller Controller issues, panics area/cron-workflows area/workflow-templates type/feature Feature request
Projects
None yet
Milestone
No milestone
3 participants
@terrytangyuan @agilgur5 @juliev0