retryStrategy does not work correctly when we use hook #11589
Labels
Comments
|
Thanks for finding root cause! Please consider contributing a PR. |
|
By the way, there are some other open issues related to hooks. I wonder if any of them are the same root cause. |
|
Good point. I'm not sure, but |
|
Is this a regression? |
|
I think it's not a regression. |
|
Appendix: Originally I reported for WorkflowLevelHook, but I can reproduce this issue for WorkflowTemplateLevelHook spec:
templates:
- name: main
steps:
- - name: s1
template: argosay
hooks:
failed:
template: hook
arguments: {}
expression: steps.s1.status == "Failed"
running:
template: hook
arguments: {}
expression: steps.s1.status == "Running"
succeed:
template: hook
arguments: {}
expression: steps.s1.status == "Succeeded"
- name: argosay
inputs: {}
outputs: {}
metadata: {}
container:
name: ''
image: argoproj/argosay:v2
command:
- /bin/sh
- '-c'
args:
- /bin/sleep 2; exit 1; /argosay
resources: {}
retryStrategy:
limit: 3
- name: hook
inputs: {}
outputs: {}
metadata: {}
container:
name: ''
image: argoproj/argosay:v2
command:
- /bin/sh
- '-c'
args:
- /bin/sleep 2; /argosay
resources: {}
entrypoint: main
arguments: {}
hooks:
failed:
template: hook
arguments: {}
expression: workflow.status == "Failed"
running:
template: hook
arguments: {}
expression: workflow.status == "Running"
succeed:
template: hook
arguments: {}
expression: workflow.status == "Succeeded" |
juliev0
pushed a commit
that referenced
this issue
Oct 15, 2023
agilgur5
added
the
area/retry-manual
3 tasks
3 tasks
terrytangyuan
pushed a commit
that referenced
this issue
Nov 3, 2023
agilgur5
added
area/retryStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pre-requisites
:latestWhat happened/what you expected to happen?
Abstract
Root cause
lastChiledNodeargo-workflows/workflow/controller/operator.go
Line 917 in e46202a
lastChiledNode= Running Node is succeeded. This node is retried node usually.argo-workflows/workflow/controller/operator.go
Line 943 in e46202a
How to fix
lastChiledNodeis last retried node.Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: