-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retryStrategy does not work correctly when we use hook #11589
Labels
Comments
Thanks for finding root cause! Please consider contributing a PR. |
By the way, there are some other open issues related to hooks. I wonder if any of them are the same root cause. |
Good point. I'm not sure, but |
Is this a regression? |
I think it's not a regression. |
juliev0
pushed a commit
that referenced
this issue
Oct 15, 2023
agilgur5
added
the
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
label
Oct 15, 2023
3 tasks
3 tasks
terrytangyuan
pushed a commit
that referenced
this issue
Nov 3, 2023
agilgur5
added
area/retryStrategy
Template-level retryStrategy
and removed
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
labels
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Pre-requisites
:latest
What happened/what you expected to happen?
Abstract
Root cause
lastChiledNode
argo-workflows/workflow/controller/operator.go
Line 917 in e46202a
lastChiledNode
= Running Node is succeeded. This node is retried node usually.argo-workflows/workflow/controller/operator.go
Line 943 in e46202a
How to fix
lastChiledNode
is last retried node.Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: