[master branch only] UI crashes when clicking node with an error message: Buffer is not defined

[toyamagu-2021]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

THIS DOES NOT RELATES TO RELEASED IMAGES either v3.5.0-rc nor v3.10.0.
Might be local development only?

• Summary
  • UI crashes when we click a node hello1.
  • Curiously, step-mnss7 is ok.
  • 
  • 
• Procedure
  • checkout master branch
  • make start UI=true
• My Env
  • WSL
  • k3d

Version

master

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: steps-
spec:
  entrypoint: hello-hello-hello

  # This spec contains two templates: hello-hello-hello and whalesay
  templates:
  - name: hello-hello-hello
    # Instead of just running a container
    # This template has a sequence of steps
    steps:
    - - name: hello1            # hello1 is run before the following steps
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "hello1"
    - - name: hello2a           # double dash => run after previous step
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "hello2a"
      - name: hello2b           # single dash => run in parallel with previous step
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "hello2b"

  # This is the same template as from the previous example
  - name: whalesay
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay
      command: [cowsay]
      args: ["{{inputs.parameters.message}}"]

### Logs from the workflow controller

```text
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[terrytangyuan]

Might be related to recent dependency updates? cc @agilgur5

[toyamagu-2021]

I'm not completely sure, but aac4f89 might cause this problem.
Previous commits are ok.

[agilgur5]

I can check if I can reproduce. All of my PRs I had no errors locally, but maybe when mixed with dependabot updates something broke.

[agilgur5]

I'm not completely sure, but aac4f89 might cause this problem.
Previous commits are ok.

Buffer is not defined

So #11628 upgraded to Webpack v5, which no longer auto-adds Node polyfills (this is normally fine for browsers b/c browser code shouldn't rely on Node). Specifically, I believe Buffer is one of them.
In #11418 (comment) I got a build error on Buffer not resolving. That was because the dependency was not resolving to the browser variant (due to outdated tsconfig, typescript, etc)

This is a run-time error though, so that suggests that a dep might be using Buffer as a global (i.e. did not explicitly import it) 🤔

[agilgur5]

Oh. That is internal code using Buffer:

argo-workflows/ui/src/app/shared/pod-name.ts

Line 38 in 94fbb3b

const data = Buffer.from(input);

.

That probably requires a polyfill now. I'll look into that.

[agilgur5]

TIL what an FNV hash is. This comes from 2 year old code in #6925, which was quite literally intended to duplicate server-side code per #6865 (comment).

So that makes a bit more sense why server-side JS is being used 😅

Ideally we might be able to replace the hash function with a library that works client-side, but if not, will add a polyfill

[toyamagu-2021]

Great! Thank you!

Just in case, this regression is not included in v3.4.11.
(It's obvious considering problematic commit is not included in cherry-pick candidate.)
I've checked this by checking out to release-3.4.11 and create local environment.

[terrytangyuan]

Yeah I intentionally didn't include those UI changes since they are relatively new and not thoroughly tested yet. Thanks for confirming.

[agilgur5]

Yea the UI build system being upgraded a major version is definitely more of a risky change and certainly not a bugfix 😅

Idk how long 3.4.x will get backports for (this is the first minor release I've been part of), but if it's a while, we may eventually want to add some of the UI deps changes so that it doesn't diverge too far (as that could heavily complicate UI backports).

[agilgur5]

Managed to find a pretty tiny fix that didn't need a polyfill or another library.

See #11766