-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master branch only] UI crashes when clicking node with an error message: Buffer is not defined
#11764
Comments
Might be related to recent dependency updates? cc @agilgur5 |
I'm not completely sure, but aac4f89 might cause this problem. |
I can check if I can reproduce. All of my PRs I had no errors locally, but maybe when mixed with dependabot updates something broke. |
So #11628 upgraded to Webpack v5, which no longer auto-adds Node polyfills (this is normally fine for browsers b/c browser code shouldn't rely on Node). Specifically, I believe This is a run-time error though, so that suggests that a dep might be using |
Oh. That is internal code using
That probably requires a polyfill now. I'll look into that. |
TIL what an FNV hash is. This comes from 2 year old code in #6925, which was quite literally intended to duplicate server-side code per #6865 (comment). So that makes a bit more sense why server-side JS is being used 😅 Ideally we might be able to replace the hash function with a library that works client-side, but if not, will add a polyfill |
Great! Thank you! Just in case, this regression is not included in v3.4.11. |
Yeah I intentionally didn't include those UI changes since they are relatively new and not thoroughly tested yet. Thanks for confirming. |
Yea the UI build system being upgraded a major version is definitely more of a risky change and certainly not a bugfix 😅 Idk how long 3.4.x will get backports for (this is the first minor release I've been part of), but if it's a while, we may eventually want to add some of the UI deps changes so that it doesn't diverge too far (as that could heavily complicate UI backports). |
Managed to find a pretty tiny fix that didn't need a polyfill or another library. See #11766 |
Buffer is not defined
Pre-requisites
:latest
What happened/what you expected to happen?
THIS DOES NOT RELATES TO RELEASED IMAGES either v3.5.0-rc nor v3.10.0.
Might be local development only?
hello1
.step-mnss7
is ok.make start UI=true
Version
master
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: