-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to CronWorkflows from UI not persisting #12048
Comments
@agilgur5 This seems related to front-end refactoring since backend works as expected |
There were actually no recent refactors to the So I'm not sure if that's related.
A refresh of the page should also get fresh data (we don't store Workflows in Let me see if I can reproduce, may need more details |
I couldn't reproduce this locally. It's updating and persisting fine for me.
I might hazard a guess that the modification didn't reach the k8s API correctly. But if you got a successful response, that usually means the whole chain was successful. Is your actual |
No |
More logs when i am pressing "update":
Controller:
I am wondering if old CRDs might cause this behaviour? |
Ok, so this isn't a UI issue then. I'm not really sure why your Server is responding with a 200 if it didn't actually succeed in k8s. Is there any error in your browser console? Might want to try turning on debug logging on the Server as well.
Usually the CRDs only impact validation of new specs, but I'm not sure how old they are and, more generally speaking, there can be undefined behavior when versions are mixed |
Another culprit to check for, although this would normally throw an error, is your RBAC properly set to allow updating of Cron Workflows? |
I found the issue. Miss-configured ignoreDifferences on the Argo CD side + selfHeal: true in application params. Argo CD was changing k8s resource back to default state very fast, this is why i was not able to see any changes in k8s manifest. Sorry guys, this is really stupid from me. off topic: do you know why controller updating aws LB configmap? |
It's probably not updating it, but the Controller does watch for ConfigMap updates as certain features use ConfigMaps (e.g. synchronization, passing arguments from a ConfigMap, auto-updating when the |
Pre-requisites
:latest
What happened/what you expected to happen?
I am updating cron expression from the UI to any new valid expression. Pressing "UPDATE". Can see "Updated" notification and successful
PUT
request to backend. But after refreshing the page, i can see old value again.In logs i can not see anything abnormal near accepted
method=PUT
request.Maybe something missing in my configuration? But anyway, why then i see "Updated" notification if it not works.
Version
v3.5.0
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Any
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: