Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support displaying line numbers in object-editor #12807

Closed
ishivanshgoel opened this issue Mar 14, 2024 · 2 comments · Fixed by #12873
Closed

Support displaying line numbers in object-editor #12807

ishivanshgoel opened this issue Mar 14, 2024 · 2 comments · Fixed by #12873
Labels
area/ui good first issue Good for newcomers solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request

Comments

@ishivanshgoel
Copy link

ishivanshgoel commented Mar 14, 2024 •
edited by agilgur5

Summary

Adding support for displaying the line number would enhance the user experience, as it would aid in debugging

What change needs making?

Needs to pass on instead of off as a value for lineNumbers key/just remove the off as be default it will be on in SuspenseMonacoEditor.

When would you use this?

Useful for debugging

Following is the reference to the codebase:
lineNumbers: 'off'

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.
@ishivanshgoel ishivanshgoel added the type/feature Feature request label Mar 14, 2024
@agilgur5
Copy link
Member

Looking at the git blame, that line originates from #4470, which is the first commit that moved the UI into this repo (and Monaco appears to not have existed prior to that in argoproj/argo-ui#53). So there's no rationale listed for why it's off.

Would you like to test removing that line, ensure everything still works, and submit a PR with screenshots?

@ishivanshgoel
Copy link
Author

@agilgur5 sure, let me try. I would need sometime for setting up project locally for development, will refer to the contributing guide.

@agilgur5 agilgur5 added good first issue Good for newcomers solution/suggested A solution to the bug has been suggested. Someone needs to implement it. labels Mar 18, 2024
alizademhdi added a commit to alizademhdi/argo-workflows that referenced this issue Apr 2, 2024
@alizademhdi
feat: displaying line number in object-editor. Fixes argoproj#12807
a2397b9 
Signed-off-by: alizademhdi <alizademhdi@gmail.com>
@alizademhdi alizademhdi mentioned this issue Apr 2, 2024
Merged
@agilgur5 agilgur5 changed the title Support displaying line number in object-editor Support displaying line numbers in object-editor Apr 3, 2024
alizademhdi added a commit to alizademhdi/argo-workflows that referenced this issue Apr 3, 2024
@alizademhdi
feat: displaying line number in object-editor. Fixes argoproj#12807
c6a8d65 
Signed-off-by: alizademhdi <alizademhdi@gmail.com>
agilgur5 pushed a commit that referenced this issue Apr 3, 2024
@alizademhdi
feat(ui): display line numbers in object-editor. Fixes #12807. (#12873)
74eb722 
Signed-off-by: alizademhdi <alizademhdi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui good first issue Good for newcomers solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request
Projects
Argo Workflows UI/UX Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): display line numbers in object-editor. Fixes #12807. alizademhdi/argo-workflows
2 participants
@agilgur5 @ishivanshgoel