Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[argo-ui] css loads Heebo font from the internet #1376

Closed
devlounge opened this issue May 24, 2019 · 5 comments · Fixed by #2971
Closed

[argo-ui] css loads Heebo font from the internet #1376

devlounge opened this issue May 24, 2019 · 5 comments · Fixed by #2971
Assignees
@alexec
Labels
area/ui good first issue Good for newcomers type/security Security related

Comments

@devlounge
Copy link

devlounge commented May 24, 2019 •
edited

Is this a BUG REPORT or FEATURE REQUEST?:
Bug report

What happened:
While loading the Argo UI, the CSS tries to load Heebo from fonts.googleapis,.com.
BUT, in air-gapped environments, users workstations do NOT have any internet connection
-> It can take more than 1 to 2 minutes before the page renders (I guess CSS falls back to browser fonts instead)
-> The fallback font used in the left navbar popovers is rendered all blurred

What you expected to happen:
Bundle the fonts in the docker image and serve them from disk

Environment:

  • Argo version: v2.3.0
  • Kubernetes version : v1.13.4
@devlounge
Copy link
Author

devlounge commented Jul 17, 2019 •
edited

Any update on this?
Same issue when using ArgoCDd UI

@ZhengRongTan
Copy link

same issue
access https://fonts.googleapis.com/css?family=Heebo:300,400,500,700

@devlounge
Copy link
Author

Hi,

We need a fix for this, because this makes it annoying to use in corporate air-tight environments.

@alexec
Copy link
Contributor

alexec commented Jan 17, 2020

Would you like to submit a PR to fix this?

@alexec alexec added the good first issue Good for newcomers label Apr 24, 2020
@alexec
Copy link
Contributor

alexec commented Apr 24, 2020

Should combine with #2760

@alexec alexec added the type/security Security related label Apr 24, 2020
@alexec alexec self-assigned this May 7, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue May 7, 2020
@alexec
feat(ui) Enable CSP, HSTS, X-Frame-Options. Fixes argoproj#2760, argo…
dd40d05 
…proj#1376, argoproj#2761
@alexec alexec mentioned this issue May 7, 2020
Merged
6 tasks
alexec added a commit that referenced this issue May 13, 2020
@alexec
feat(ui): Enable CSP, HSTS, X-Frame-Options. Fixes #2760, #1376, #2761 (
9f86a4e 
#2971)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
area/ui good first issue Good for newcomers type/security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): Enable CSP, HSTS, X-Frame-Options. Fixes #2760, #1376, #2761 alexec/argo-workflows
4 participants
@alexec @devlounge @agilgur5 @ZhengRongTan