Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cookie security #2759

Closed
alexec opened this issue Apr 20, 2020 · 2 comments · Fixed by #2763
Closed

Improve cookie security #2759

alexec opened this issue Apr 20, 2020 · 2 comments · Fixed by #2763
Labels

Comments

@alexec
Copy link
Contributor

alexec commented Apr 20, 2020

After investigating SSO, I think we need to improve this:

  • Remove display the cookie from the login page.
  • Set-up flags, []string{"path=/", "SameSite=lax", "httpOnly"} but not Secure.

@alexmt why does Argo CD use "lax" not "strict"?

OSWAP

This is probably the most secure configuration we have for
now:
Set-Cookie: __Host-SessionID=3h93...;Path=/;Secure;HttpOnly;SameSite=Strict

@alexec alexec added type/bug type/security Security related labels Apr 20, 2020
@alexec
Copy link
Contributor Author

alexec commented Apr 20, 2020

@jannfis @alexmt FYI

@alexec
Copy link
Contributor Author

alexec commented Apr 20, 2020

ok, we don't currently need to set path, because we set the cookie client side in javascript

alexec added a commit to alexec/argo-workflows that referenced this issue Apr 20, 2020
@alexec alexec linked a pull request Apr 20, 2020 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant