Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Labels - Annotations on Rows #2782

Closed
ericmeadows opened this issue Apr 22, 2020 · 7 comments
Closed

Workflow Labels - Annotations on Rows #2782

ericmeadows opened this issue Apr 22, 2020 · 7 comments
Assignees
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@ericmeadows
Copy link

Summary

Add labels to each workflow row for custom Workflow labels.

Motivation

We have some developers that want to be able to have a quick look at the workflows, and not all understand the way to filter through the massive list of values in the list.

Proposal

How do you think this should be implemented?

Add random, or configMap specifiable labels to each row, giving simple visual representation of what labels are present for a given build. When a label is clicked on, this should then filter the list down to only include those whose values are equal to the given label.

See EXP1 below.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@ericmeadows ericmeadows added the type/feature Feature request label Apr 22, 2020
@alexec
Copy link
Contributor

alexec commented Apr 22, 2020

This is a great idea! But, what is the app in the screenshot? It is not Argo Workflows AFAIK?

@alexec alexec added good first issue Good for newcomers help wanted labels Apr 22, 2020
@ericmeadows
Copy link
Author

@alexec - it is not. It was a React app that I figured would be an example. Another one would be GitHub's labels...

@rbreeze
Copy link
Member

rbreeze commented May 29, 2020

I can work on this one

@ericmeadows
Copy link
Author

ericmeadows commented May 29, 2020 via email

@rbreeze
Copy link
Member

rbreeze commented Jun 1, 2020

@ericmeadows Was something like this what you were envisioning? I haven't added the tooltip on hover yet but will update you when I do.

Screen Shot 2020-06-01 at 10 19 04 AM

@sarabala1979
Copy link
Member

@rbreeze thanks for taking more issues. I would recommend having multiline text or scrollable label. So it can display all labels/annotations in one place with scroll and we can save some realestate

image

@rbreeze
Copy link
Member

rbreeze commented Jun 1, 2020

@sarabala1979 good idea, thanks! As I have it, the labels are multiline, just not demonstrated in the screenshot. But some sort of scroll interface would probably help for workflows with dozens of labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants