Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have millisecond-level timestamps in argoexec? #2795

Closed
mikhailian opened this issue Apr 23, 2020 · 4 comments
Closed

Can we have millisecond-level timestamps in argoexec? #2795

mikhailian opened this issue Apr 23, 2020 · 4 comments
Assignees
Labels
type/feature Feature request

Comments

@mikhailian
Copy link
Contributor

mikhailian commented Apr 23, 2020

Summary

Currently, timestamps are time="2020-04-23T08:28:23Z" , it would help to have milliseconds included, e.g. time="2020-04-23T08:28:23.000Z"

Motivation

argoexec spawns short-lived processes where milliseconds matter.

Proposal

diff --git a/cmd/argoexec/main.go b/cmd/argoexec/main.go
index 99c6b4d3..5de968ab 100644
--- a/cmd/argoexec/main.go
+++ b/cmd/argoexec/main.go
@@ -14,6 +14,11 @@ import (
 )

 func main() {
+  logger := &logrus.Logger{
+      Formatter: &logrus.TextFormatter{
+      TimestampFormat : "2006-01-02 15:04:05.000Z",
+    },
+  }
        if err := commands.NewRootCommand().Execute(); err != nil {
                fmt.Println(err)
                os.Exit(1)

@mikhailian mikhailian added the type/feature Feature request label Apr 23, 2020
@mikhailian mikhailian changed the title Can we have millisecond-level timestamps in argoexec or everywhere? Can we have millisecond-level timestamps in argoexec? Apr 23, 2020
@alexec
Copy link
Contributor

alexec commented Apr 23, 2020

Would you like to summit a PR?

@aistein
Copy link
Contributor

aistein commented Apr 23, 2020

@alexec I would like to give this a try

@simster7
Copy link
Member

@aistein Assigned

@simster7
Copy link
Member

Closed in #2950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants